Page MenuHomePhabricator

[native] Deprecate react-native-dark-mode
ClosedPublic

Authored by ashoat on Nov 10 2022, 1:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 6:33 AM
Unknown Object (File)
Sun, Nov 24, 6:33 AM
Unknown Object (File)
Sun, Nov 24, 6:33 AM
Unknown Object (File)
Sun, Nov 24, 6:33 AM
Unknown Object (File)
Sat, Nov 2, 9:57 PM
Unknown Object (File)
Sat, Nov 2, 9:57 PM
Unknown Object (File)
Sat, Nov 2, 9:57 PM
Unknown Object (File)
Sat, Nov 2, 9:54 PM
Subscribers

Details

Summary

I'm working on ENG-614 to update React Native. The latest version of react-native-dark-mode had issues building on Android, and support for this functionality was introduced into the React Native core a while back anyways.

This diff deprecates react-native-dark-mode in favor of using the built-in Appearance module in React Native.

Test Plan

I tested this diff on the latest master and deployed it to my iOS device. I then set the iOS device to defer to the OS for dark mode, and swapped the OS settings and confirmed the app also swapped its setting

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable