Page MenuHomePhabricator

Revert "[native] Remove `sortBy` property from `fetchPhotos`"
ClosedPublic

Authored by atul on Nov 30 2022, 4:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:15 AM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
Unknown Object (File)
Thu, Oct 24, 5:20 PM
Unknown Object (File)
Thu, Oct 24, 5:15 PM
Unknown Object (File)
Oct 2 2024, 9:37 PM
Unknown Object (File)
Oct 2 2024, 9:37 PM
Unknown Object (File)
Oct 2 2024, 9:37 PM
Unknown Object (File)
Oct 2 2024, 9:34 PM
Subscribers

Details

Summary

This reverts commit 091b31930a107ddbbb73be29ccdf8649235e2e62.

Context: https://linear.app/comm/issue/ENG-1481/revisit-medialibrary-sortby
Additional context: https://linear.app/comm/issue/ENG-2111/max-sees-old-images-ahead-of-recent-ones-in-image-gallery

Basically @max and I and others noticed that the sort order of images in the MediaGalleryKeyboard appears incorrect. This seems to be the case both on Android and iOS (see Linear issues for further discussion).

The changes in D4836 were intended to address an issue where media was being "pushed to the front" when viewed/edited because MediaGalleryKeyboard was sorting by modificationTime.

However, after that diff was landed I noticed that the order of media in MediaGalleryKeyboard was not as expected on my personal iOS device. In addition, after pushing build 159 to prod on Android, I got feedback that media appeared to be sorted in the wrong order... specifically that it seemed like media was being sorted alphabetically based on the names of the folders in which they lived.

This diff reverts the sort order to what it was in build 131 (last public App Store/Play Store release)

Test Plan

Pushed release build to my phone (iOS) and things appear as expected.

But generally this should match behavior of existing "public" release, so I think this is a safe/predictable change.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul edited the summary of this revision. (Show Details)
atul edited the summary of this revision. (Show Details)
atul edited the summary of this revision. (Show Details)
atul edited the summary of this revision. (Show Details)
atul published this revision for review.Nov 30 2022, 4:25 PM
atul edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 30 2022, 4:37 PM