Paths

Table of Contentst

Differential D5887

[keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB
ClosedPublic
Actions

Authored by atul on Dec 16 2022, 12:02 PM.

Tags

None

Referenced Files

	F2188028: D5887.id19688.diff
	Thu, Jul 4, 7:55 AM

	Unknown Object (File)
	Thu, Jul 4, 12:46 AM

	Unknown Object (File)
	Wed, Jul 3, 9:24 PM

	Unknown Object (File)
	Tue, Jul 2, 2:51 PM

	Unknown Object (File)
	Sun, Jun 30, 10:32 PM

	Unknown Object (File)
	Sun, Jun 30, 9:04 AM

	Unknown Object (File)
	Fri, Jun 21, 8:46 PM

	Unknown Object (File)
	Fri, Jun 21, 8:45 PM

Subscribers

None

Details

Reviewers

tomek
ashoat

Commits

rCOMM7daa8a0cb31a: [keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB

Summary

Introduce createSIWENonceEntry in siwe-nonce-creator and consume in siweNonceResponder to persist nonce entry in DB.

If there is already an existing entry for a given ethereum_address, createSIWENonceEntry will update the current entry in place. However, this may prevent a user from signing in with ethereum on two devices with the same wallet at the same time. We can add a deviceID column to the siwe_nonces column to handle that scenario and create a (deviceID, ethereum_address) composite key or something.

Depends on D5885

Test Plan

nonces generated in response to client hitting siwe_nonce endpoint are persisted in the serverDB:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 16 2022, 12:02 PM

atul published this revision for review.Dec 16 2022, 12:03 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B14209: Diff 19442.Dec 16 2022, 12:14 PM

Don't land until you connect the nonce to a specific session please

This revision is now accepted and ready to land.Dec 16 2022, 1:15 PM

fix

Harbormaster failed remote builds in B14214: Diff 19448!Dec 17 2022, 3:11 PM

Harbormaster completed remote builds in B14214: Diff 19448.Dec 17 2022, 4:11 PM

ashoat requested changes to this revision.Dec 19 2022, 9:23 AM

ashoat added inline comments.

keyserver/src/responders/siwe-nonce-responders.js
12 ↗	(On Diff #19448)	I think you forgot to update this

This revision now requires changes to proceed.Dec 19 2022, 9:23 AM

atul added inline comments.Dec 19 2022, 9:24 AM

keyserver/src/responders/siwe-nonce-responders.js
12 ↗	(On Diff #19448)	Ah yeah, looks like I missed that when resolving merge conflicts, thanks for catching that

fix issue from incorrectly resolving merge conflict

ashoat accepted this revision.Dec 19 2022, 11:05 AM

This revision is now accepted and ready to land.Dec 19 2022, 11:05 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 19 2022, 11:21 AM

Closed by commit rCOMM7daa8a0cb31a: [keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7daa8a0cb31a: [keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB.

Harbormaster completed remote builds in B14431: Diff 19684.Dec 19 2022, 11:29 AM

Harbormaster completed remote builds in B14434: Diff 19687.Dec 19 2022, 11:35 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

siwe-nonce-creator.js

14 lines

responders/

siwe-nonce-responders.js

8 lines

Diff 19688

keyserver/src/creators/siwe-nonce-creator.js

Loading...

keyserver/src/responders/siwe-nonce-responders.js

Loading...