Page MenuHomePhabricator

[native] Consider null notification tag in CommNotificationsHandler
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 30, 8:49 AM
Unknown Object (File)
Mon, Sep 30, 8:49 AM
Unknown Object (File)
Mon, Sep 30, 8:49 AM
Unknown Object (File)
Mon, Sep 30, 8:48 AM
Unknown Object (File)
Sat, Sep 21, 8:15 PM
Unknown Object (File)
Sep 3 2024, 7:27 PM
Unknown Object (File)
Aug 28 2024, 5:16 PM
Unknown Object (File)
Aug 18 2024, 8:21 AM
Subscribers

Details

Summary

I noticed an error while testing my React Native 0.70 branch on Android: https://web.comm.app/upload/3959996/63ded52241732e2f

My guess is that it happened because the "empty notification" generated by react-native-background-upload (context here) does not have a tag.

Either way, the API is clear that this value can be null, so we should check for it.

Test Plan

I tested generating a rescind notif on a client after that client uploaded a message in the background and the issue did not reoccur

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable