Page MenuHomePhabricator

[lib] Handle string exception in getMessageForException
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:49 PM.
Tags
None
Referenced Files
F3506977: D5890.diff
Fri, Dec 20, 6:49 PM
Unknown Object (File)
Sat, Dec 7, 12:18 PM
Unknown Object (File)
Sat, Dec 7, 12:05 PM
Unknown Object (File)
Sat, Dec 7, 11:57 AM
Unknown Object (File)
Nov 9 2024, 2:31 AM
Unknown Object (File)
Nov 9 2024, 2:31 AM
Unknown Object (File)
Nov 9 2024, 2:24 AM
Unknown Object (File)
Nov 9 2024, 1:19 AM
Subscribers

Details

Summary

Obvious in hindsight. Only noticed this while debugging an issue where this line was seeing a string exception, which I think is coming from react-native-background-upload.

getMessageForException is meant to be a general-purpose utility, so I think it's good for us to handle this.

Test Plan

I confirmed that after this change, the mediaMissionReport sent by commbot included an exceptionMessage property that had the text of the exception

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/rn70-upgrade-extras
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:37 PM
Harbormaster failed remote builds in B14219: Diff 19453!

Something is broken with iOS CI

This revision is now accepted and ready to land.Dec 19 2022, 1:58 AM