[keyserver] Fix `siwe_nonces` table creation
ClosedPublic
Actions

Authored by atul on Dec 19 2022, 11:35 AM.

Tags

None

Referenced Files

	F3496834: D5943.diff
	Thu, Dec 19, 3:34 PM

	Unknown Object (File)
	Nov 8 2024, 9:13 PM

	Unknown Object (File)
	Nov 8 2024, 9:13 PM

	Unknown Object (File)
	Nov 8 2024, 9:12 PM

	Unknown Object (File)
	Nov 5 2024, 2:08 AM

	Unknown Object (File)
	Nov 4 2024, 8:29 AM

	Unknown Object (File)
	Nov 4 2024, 8:29 AM

	Unknown Object (File)
	Nov 4 2024, 8:29 AM

View All Files

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMM0dfb8181dfc6: [keyserver] Fix `siwe_nonces` table creation

Summary

Very stupid issue I noticed when creating a new database. The stray comma at the end causes the following:

Test Plan

Create a new DB
Run keyserver
Ensure that the script runs successfully.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 19 2022, 11:35 AM

Going to check migration again as well to double check that

atul published this revision for review.Dec 19 2022, 11:36 AM

atul edited the summary of this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)Dec 19 2022, 11:42 AM

Harbormaster completed remote builds in B14435: Diff 19689.Dec 19 2022, 11:45 AM

ashoat accepted this revision.Dec 19 2022, 11:48 AM

This revision is now accepted and ready to land.Dec 19 2022, 11:48 AM

Closed by commit rCOMM0dfb8181dfc6: [keyserver] Fix `siwe_nonces` table creation (authored by atul). · Explain WhyDec 19 2022, 12:02 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0dfb8181dfc6: [keyserver] Fix `siwe_nonces` table creation.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

setup-db.js

2 lines

Diff 19689

View Options

keyserver/src/database/setup-db.js

[keyserver] Fix `siwe_nonces` table creationClosedPublicActions