Page MenuHomePhabricator

[keyserver] Fix landing SSR
ClosedPublic

Authored by ashoat on Dec 21 2022, 6:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 1:28 PM
Unknown Object (File)
Tue, Nov 19, 1:28 PM
Unknown Object (File)
Tue, Nov 19, 1:28 PM
Unknown Object (File)
Tue, Nov 19, 1:25 PM
Unknown Object (File)
Nov 16 2024, 2:02 AM
Unknown Object (File)
Nov 16 2024, 1:35 AM
Unknown Object (File)
Nov 10 2024, 3:49 AM
Unknown Object (File)
Nov 6 2024, 6:30 AM
Subscribers

Details

Summary

Context here: https://linear.app/comm/issue/ENG-2511#comment-ec66b35a

Stripping the slash doesn't matter on web, where we don't actually use react-router for routing (we define just one route and parse the URL ourselves). However, on landing we use react-router directly, so we should make sure we don't have an extra slash.

Test Plan

Load http://localhost:3000/commlanding/keyservers and check the console log to make sure there are no SSR errors

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable