Page MenuHomePhabricator

[keyserver] Fix landing SSR
ClosedPublic

Authored by ashoat on Dec 21 2022, 6:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 3:49 AM
Unknown Object (File)
Wed, Nov 6, 6:30 AM
Unknown Object (File)
Mon, Nov 4, 9:55 AM
Unknown Object (File)
Mon, Nov 4, 9:55 AM
Unknown Object (File)
Mon, Nov 4, 9:55 AM
Unknown Object (File)
Mon, Nov 4, 9:43 AM
Unknown Object (File)
Mon, Nov 4, 8:30 AM
Unknown Object (File)
Mon, Nov 4, 3:16 AM
Subscribers

Details

Summary

Context here: https://linear.app/comm/issue/ENG-2511#comment-ec66b35a

Stripping the slash doesn't matter on web, where we don't actually use react-router for routing (we define just one route and parse the URL ourselves). However, on landing we use react-router directly, so we should make sure we don't have an extra slash.

Test Plan

Load http://localhost:3000/commlanding/keyservers and check the console log to make sure there are no SSR errors

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fixlandingssr
Lint
No Lint Coverage
Unit
No Test Coverage