Paths

Table of Contentst

Differential D6080

[CI] Try installing `protoc` with script instead of `apt`
ClosedPublic
Actions

Authored by atul on Dec 28 2022, 8:02 PM.

Tags

None

Referenced Files

	F3494838: D6080.diff
	Thu, Dec 19, 6:54 AM

	Unknown Object (File)
	Tue, Dec 10, 3:06 PM

	Unknown Object (File)
	Sat, Nov 30, 6:53 AM

	Unknown Object (File)
	Sat, Nov 30, 6:53 AM

	Unknown Object (File)
	Sat, Nov 30, 6:53 AM

	Unknown Object (File)
	Sat, Nov 30, 6:52 AM

	Unknown Object (File)
	Thu, Nov 28, 10:36 PM

	Unknown Object (File)
	Thu, Nov 28, 10:36 PM

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMMe0cc8c5343ed: [CI] Try installing `protoc` with script instead of `apt`
rCOMM5ed525b49031: [CI] Try installing `protoc` with script instead of `apt`
rCOMM9359ba8ef73a: [CI] Try installing `protoc` with script instead of `apt`

Summary

Try installing protoc with the same script we use for Buildkite agents.

Test Plan

It's annoying to test GitHub Actions workflows without creating a fork and whatnot. If this fails it should be easy to revert.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 28 2022, 8:02 PM

atul published this revision for review.Dec 28 2022, 8:03 PM

Okay accepting to test

This revision is now accepted and ready to land.Dec 28 2022, 8:09 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 28 2022, 8:12 PM

Closed by commit rCOMM9359ba8ef73a: [CI] Try installing `protoc` with script instead of `apt` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9359ba8ef73a: [CI] Try installing `protoc` with script instead of `apt`.

Harbormaster completed remote builds in B14870: Diff 20281.Dec 28 2022, 8:17 PM

Harbormaster completed remote builds in B14871: Diff 20282.Dec 28 2022, 8:25 PM

atul added a reverting change: rCOMMc6d644b1ddb7: Revert "[CI] Try installing `protoc` with script instead of `apt`".Dec 28 2022, 10:20 PM

It should be /native/android/scripts not /scripts

This revision is now accepted and ready to land.Dec 28 2022, 10:20 PM

fix path

This revision was landed with ongoing or failed builds.Dec 28 2022, 10:22 PM

Closed by commit rCOMM5ed525b49031: [CI] Try installing `protoc` with script instead of `apt` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5ed525b49031: [CI] Try installing `protoc` with script instead of `apt`.

Harbormaster completed remote builds in B14872: Diff 20284.Dec 28 2022, 10:35 PM

atul added a reverting change: rCOMMda71341522a6: Revert "[CI] Try installing `protoc` with script instead of `apt`".Dec 28 2022, 11:47 PM

Still failed, suspect it may be a permissions issue. Going to try one more time prefixing sudo and then will reevaluate (probably makes sense to iterate on a forked repo instead of reverting/reopening again and again)

This revision is now accepted and ready to land.Dec 28 2022, 11:50 PM

prepend sudo

This revision was landed with ongoing or failed builds.Dec 28 2022, 11:53 PM

Closed by commit rCOMMe0cc8c5343ed: [CI] Try installing `protoc` with script instead of `apt` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMe0cc8c5343ed: [CI] Try installing `protoc` with script instead of `apt`.

Harbormaster completed remote builds in B14874: Diff 20288.Dec 29 2022, 12:07 AM

Revision Contents
Changeset List

Path

Size

.github/

workflows/

5 lines

android_release.yml

5 lines

Diff 20289

.github/workflows/android_ci.yml

Loading...

.github/workflows/android_release.yml

Loading...