Page MenuHomePhabricator

[web] Add SIWE dependencies to `web/package.json`
ClosedPublic

Authored by atul on Jan 5 2023, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 10:11 AM
Unknown Object (File)
Tue, Dec 31, 10:11 AM
Unknown Object (File)
Tue, Dec 31, 10:11 AM
Unknown Object (File)
Tue, Dec 31, 10:00 AM
Unknown Object (File)
Tue, Dec 31, 9:18 AM
Unknown Object (File)
Nov 30 2024, 4:04 PM
Unknown Object (File)
Nov 30 2024, 10:10 AM
Unknown Object (File)
Nov 30 2024, 10:09 AM
Subscribers
None

Details

Summary

Copy/pasting the SIWE dependencies from landing to web.

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Jan 5 2023, 12:24 AM

rainbowkit and wagmi are a couple of months old - at some point we can consider updating them (maybe after the initial release?)

This revision is now accepted and ready to land.Jan 5 2023, 9:14 AM

Should we use the same approach as native (iframe to login)? See Linear comment here

In D6171#185304, @tomek wrote:

rainbowkit and wagmi are a couple of months old - at some point we can consider updating them (maybe after the initial release?)

Unfortunately this is blocked on the Webpack 5 update (ENG-114) because newer versions of wagmi have optional chaining (or maybe nullish coalescing?), which Webpack 5 can't handle directly without Babel. (Technically possible to add a Babel layer for it in Webpack 4, but we should probably just update already.)

Should we use the same approach as native (iframe to login)? See Linear comment here

My instinct is that embedding an iframe would introduce additional complexity (passing data between host and embedded page, tying nonce to "session" which we discussed we wanted to do for web, etc) which I'd like to avoid if possible. If we were to go with an iframe, I don't think landing would be the "right" place for it... but I guess since we're already using it for SIWE on native it isn't crazy.

I've been working on integrating SIWE on web directly, but if there's a strong case for iframe approach it would be good to get clarity asap to avoid wasted work.