Page MenuHomePhabricator
Differential D6218

[web] Add `siweButton` to `LogInForm` component
ClosedPublic
Actions

Authored by atul on Jan 10 2023, 1:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 4:23 AM
Unknown Object (File)
Thu, Nov 28, 4:23 AM
Unknown Object (File)
Thu, Nov 28, 4:23 AM
Unknown Object (File)
Thu, Nov 28, 4:23 AM
Unknown Object (File)
Mon, Nov 25, 10:50 PM
Unknown Object (File)
Nov 5 2024, 4:28 AM
Unknown Object (File)
Nov 4 2024, 7:06 AM
Unknown Object (File)
Nov 3 2024, 1:30 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMfa7a753bbe74: [web] Add `siweButton` to `LogInForm` component
Summary

Doesn't do anything at the moment.

Depends on D6217

Test Plan

Here's how it looks:

c78a10-1.png (934×958 px, 110 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 10 2023, 1:29 PM
atul added inline comments.Jan 10 2023, 1:31 PM
web/account/log-in-form.react.js
170 ↗(On Diff #20760)

Using this instead of the two-tone SVG used on native because it looks better IMO in this context (where it is smaller on the page). Can bring up during discussion with design team.

atul published this revision for review.Jan 10 2023, 1:31 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B15230: Diff 20760.Jan 10 2023, 1:44 PM
atul edited the summary of this revision. (Show Details)Jan 10 2023, 2:29 PM
atul added a parent revision: D6217: [web] Introduce `LoginFormWrapper` component.
atul added a child revision: D6219: [web] Add `<hr />` in `LogInForm` to separate out "password" and SIWE options.
ashoat accepted this revision.Jan 10 2023, 7:15 PM

Won't block this on design, but not convinced we need a separate graphic / button style for web...

Let's revisit when discussing design

This revision is now accepted and ready to land.Jan 10 2023, 7:15 PM
atul added a comment.Jan 11 2023, 1:47 PM

Let's revisit when discussing design

Sounds good, will make sure to mention to David

atul updated this revision to Diff 20816.Jan 11 2023, 1:48 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 11 2023, 1:49 PM
Closed by commit rCOMMfa7a753bbe74: [web] Add `siweButton` to `LogInForm` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMfa7a753bbe74: [web] Add `siweButton` to `LogInForm` component.
Harbormaster completed remote builds in B15264: Diff 20816.Jan 11 2023, 2:04 PM

Revision Contents
Changeset List

PathSize
web/
account/
7 lines
24 lines

Diff 20817

View Options

web/account/log-in-form.css

Loading...
View Options

web/account/log-in-form.react.js

Loading...