convert generatesNotif to return a enum, either NOTIF or RESCIND, or undefined if the message type should not send a push notif.
Linear Task: ENG-2644
Details
Details
flow also tested chat creation, message creation, message liking/unliking, and adding members to a chat
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think it would be good to update message-creator.js in this diff, so doesGenerateNotif ? messageInfo : undefined checks if it's pushTypes.NOTIF specifically. As of this revision, returning RESCIND would result in a new push notif being sent, which seems unexpected
Comment Actions
Please address comment before landing
| keyserver/src/creators/message-creator.js | ||
|---|---|---|
| 400 ↗ | (On Diff #20832) | We don't need the start of this |