Paths

Table of Contentst

Differential D6239

[lib/keyserver] convert generatesNotif to return a enum
ClosedPublic
Actions

Authored by ginsu on Jan 11 2023, 12:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 26, 6:30 AM

	Unknown Object (File)
	Sun, Jan 26, 6:30 AM

	Unknown Object (File)
	Sun, Jan 26, 6:30 AM

	Unknown Object (File)
	Sun, Jan 26, 6:30 AM

	Unknown Object (File)
	Sun, Jan 26, 6:30 AM

	Unknown Object (File)
	Sun, Jan 26, 6:29 AM

	Unknown Object (File)
	Jan 10 2025, 7:27 PM

	Unknown Object (File)
	Dec 15 2024, 1:46 PM

View All 94 Files

Subscribers

Details

Reviewers

atul
ashoat
tomek

Commits

rCOMM2b08c6c1367b: [lib/keyserver] convert generatesNotif to return a enum

Summary

convert generatesNotif to return a enum, either NOTIF or RESCIND, or undefined if the message type should not send a push notif.

Linear Task: ENG-2644

Test Plan

flow also tested chat creation, message creation, message liking/unliking, and adding members to a chat

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 11 2023, 12:11 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2023, 12:11 PM

ginsu edited the summary of this revision. (Show Details)Jan 11 2023, 12:13 PM

ginsu added reviewers: ashoat, tomek.

Harbormaster completed remote builds in B15262: Diff 20810.Jan 11 2023, 12:26 PM

ginsu requested review of this revision.Jan 11 2023, 12:26 PM

I think it would be good to update message-creator.js in this diff, so doesGenerateNotif ? messageInfo : undefined checks if it's pushTypes.NOTIF specifically. As of this revision, returning RESCIND would result in a new push notif being sent, which seems unexpected

This revision now requires changes to proceed.Jan 11 2023, 12:57 PM

address ashoat's comments

ginsu retitled this revision from [lib] convert generatesNotif to return a enum to [lib/keyserver] convert generatesNotif to return a enum.Jan 11 2023, 4:10 PM

Harbormaster completed remote builds in B15276: Diff 20832.Jan 11 2023, 4:22 PM

Please address comment before landing

keyserver/src/creators/message-creator.js
400 ↗	(On Diff #20832)	We don't need the start of this

This revision is now accepted and ready to land.Jan 11 2023, 6:53 PM

address ashoat's comments

Harbormaster completed remote builds in B15279: Diff 20837.Jan 11 2023, 8:15 PM

Closed by commit rCOMM2b08c6c1367b: [lib/keyserver] convert generatesNotif to return a enum (authored by ginsu). · Explain WhyJan 11 2023, 8:16 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM2b08c6c1367b: [lib/keyserver] convert generatesNotif to return a enum.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

5 lines

lib/

shared/

messages/

add-members-message-spec.js

2 lines

change-role-message-spec.js

15 lines

change-settings-message-spec.js

13 lines

create-entry-message-spec.js

11 lines

create-sidebar-message-spec.js

13 lines

create-sub-thread-message-spec.js

17 lines

create-thread-message-spec.js

15 lines

delete-entry-message-spec.js

11 lines

edit-entry-message-spec.js

11 lines

join-thread-message-spec.js

2 lines

leave-thread-message-spec.js

2 lines

message-spec.js

8 lines

multimedia-message-spec.js

14 lines

reaction-message-spec.js

15 lines

remove-members-message-spec.js

2 lines

restore-entry-message-spec.js

11 lines

sidebar-source-message-spec.js

2 lines

text-message-spec.js

12 lines

unsupported-message-spec.js

8 lines

update-relationship-message-spec.js

13 lines

Diff 20838

keyserver/src/creators/message-creator.js

Loading...

lib/shared/messages/add-members-message-spec.js

Loading...

lib/shared/messages/change-role-message-spec.js

Loading...

lib/shared/messages/change-settings-message-spec.js

Loading...

lib/shared/messages/create-entry-message-spec.js

Loading...

lib/shared/messages/create-sidebar-message-spec.js

Loading...

lib/shared/messages/create-sub-thread-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/delete-entry-message-spec.js

Loading...

lib/shared/messages/edit-entry-message-spec.js

Loading...

lib/shared/messages/join-thread-message-spec.js

Loading...

lib/shared/messages/leave-thread-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/multimedia-message-spec.js

Loading...

lib/shared/messages/reaction-message-spec.js

Loading...

lib/shared/messages/remove-members-message-spec.js

Loading...

lib/shared/messages/restore-entry-message-spec.js

Loading...

lib/shared/messages/sidebar-source-message-spec.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/shared/messages/unsupported-message-spec.js

Loading...

lib/shared/messages/update-relationship-message-spec.js

Loading...