Page MenuHomePhabricator
Differential D6323

[desktop] Add zip make target
ClosedPublic
Actions

Authored by michal on Jan 20 2023, 4:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 2:54 AM
Unknown Object (File)
Wed, Oct 30, 5:58 AM
Unknown Object (File)
Wed, Oct 30, 5:58 AM
Unknown Object (File)
Wed, Oct 30, 5:58 AM
Unknown Object (File)
Wed, Oct 30, 5:54 AM
Unknown Object (File)
Oct 2 2024, 5:18 AM
Unknown Object (File)
Sep 26 2024, 8:57 AM
Unknown Object (File)
Sep 26 2024, 8:57 AM
View All 61 Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMMbc63e4c33b00: [desktop] Add zip make target
Summary

The format for the macos file for the auto updating is a zipped .app. This diff adds it to the make targets so it's created automatically. Adding ashoat because there's a new dependency.

Test Plan

Check if the .zip is correctly created.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Jan 20 2023, 4:16 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2023, 4:16 AM
Harbormaster completed remote builds in B15497: Diff 21141.Jan 20 2023, 4:27 AM
michal requested review of this revision.Jan 20 2023, 4:27 AM
ashoat accepted this revision.Jan 20 2023, 10:38 AM

Adding ashoat bec

I think you forgot to finish typing this and adding me, but I'll accept anyways :)

This revision is now accepted and ready to land.Jan 20 2023, 10:38 AM
michal edited the summary of this revision. (Show Details)Jan 23 2023, 10:11 AM

Whoops, yeah, I updated the description :)

Closed by commit rCOMMbc63e4c33b00: [desktop] Add zip make target (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyFeb 1 2023, 3:18 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMbc63e4c33b00: [desktop] Add zip make target.

Revision Contents
Changeset List

PathSize
desktop/
4 lines
1 line
15 lines

Diff 21730

View Options

desktop/forge.config.cjs

Loading...
View Options

desktop/package.json

Loading...
View Options

yarn.lock

Loading...