Page MenuHomePhabricator

[lib] Show cached ENS names on first render
ClosedPublic

Authored by ashoat on Jan 27 2023, 11:58 AM.
Tags
None
Referenced Files
F3492583: D6419.diff
Thu, Dec 19, 12:41 AM
Unknown Object (File)
Fri, Dec 6, 12:23 PM
Unknown Object (File)
Nov 3 2024, 4:44 PM
Unknown Object (File)
Nov 1 2024, 1:35 PM
Unknown Object (File)
Oct 29 2024, 6:22 PM
Unknown Object (File)
Oct 29 2024, 6:22 PM
Unknown Object (File)
Oct 29 2024, 6:22 PM
Unknown Object (File)
Oct 29 2024, 6:20 PM
Subscribers

Details

Summary

Instead of waiting for ENSCache to resolve a Promise, this diff makes it so if an ENS name is cached, we show it immediately from useStringForUser on the first render.

Depends on D6418

Test Plan

I added a console.log of the result of useStringForUser, and then logged out and back in on the iOS simulator. After this diff, the first render of useStringForUser was correct when the result was cached, but before this diff the first render had the ETH address instead of the ENS name

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage