Paths

Table of Contentst

Differential D6444

[lib] getKeyserverAdmin -> useKeyserverAdmin
ClosedPublic
Actions

Authored by ashoat on Jan 29 2023, 2:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 4:26 AM

	Unknown Object (File)
	Sun, Nov 10, 4:26 AM

	Unknown Object (File)
	Sun, Nov 10, 4:24 AM

	Unknown Object (File)
	Tue, Nov 5, 2:09 AM

	Unknown Object (File)
	Oct 3 2024, 9:20 PM

	Unknown Object (File)
	Sep 28 2024, 7:29 PM

	Unknown Object (File)
	Sep 28 2024, 5:20 PM

	Unknown Object (File)
	Sep 27 2024, 10:51 AM

View All 60 Files

Subscribers

Details

Reviewers

Commits

rCOMMdb1d5ea8028b: [lib] getKeyserverAdmin -> useKeyserverAdmin

Summary

This makes sense as a hook, and it will make it easier to incorporate useENSNames in the next diff.

Test Plan

Flow, and making sure CommunityPill on native & ChatThreadAncestors on web still look right (only two uses of this function)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 29 2023, 2:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 29 2023, 2:37 PM

ashoat added inline comments.Jan 29 2023, 2:39 PM

native/components/community-pill.react.js
22 ↗	(On Diff #21533)	I think it's okay to get rid of this `useMemo` since we're memoizing a primitive here, but if the CPU cost of `community.members.find` is judged too high I can bring it back

ashoat added a child revision: D6446: [lib] Fetch ENS name in useKeyserverAdmin.Jan 29 2023, 2:45 PM

Harbormaster completed remote builds in B15787: Diff 21533.Jan 29 2023, 2:52 PM

ashoat requested review of this revision.Jan 29 2023, 2:52 PM

atul accepted this revision.Jan 29 2023, 3:31 PM

atul edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jan 29 2023, 3:31 PM

Closed by commit rCOMMdb1d5ea8028b: [lib] getKeyserverAdmin -> useKeyserverAdmin (authored by ashoat). · Explain WhyJan 30 2023, 9:57 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdb1d5ea8028b: [lib] getKeyserverAdmin -> useKeyserverAdmin.

Revision Contents
Changeset List

Path

Size

lib/

shared/

9 lines

native/

components/

community-pill.react.js

10 lines

web/

chat/

chat-thread-ancestors.react.js

10 lines

Diff 21631

lib/shared/user-utils.js

Loading...

native/components/community-pill.react.js

Loading...

web/chat/chat-thread-ancestors.react.js

Loading...