Differential D6551

[lib] Catch exceptions thrown by ethers.js in ENSCache
ClosedPublic
Actions

Authored by ashoat on Feb 3 2023, 12:33 AM.

Details

Reviewers

atul

Commits

rCOMM787f0a3b4a6b: [lib] Catch exceptions thrown by ethers.js in ENSCache

Summary

I haven't noticed any exceptions, but it would be good to consider this.

If an exception is thrown when querying for an address, we won't try again for another 5 minutes.

Depends on D6550

Test Plan

I haven't actually noticed exceptions, but in a later point of the stack I introduce my own exceptions (for timeouts) and I confirmed things work correctly for those

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 3 2023, 12:33 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 3 2023, 12:33 AM

ashoat added a child revision: D6552: [lib] Add timeout to ENSCache.Feb 3 2023, 12:33 AM

Harbormaster completed remote builds in B16058: Diff 21932.Feb 3 2023, 12:47 AM

ashoat requested review of this revision.Feb 3 2023, 12:47 AM

atul accepted this revision.Feb 4 2023, 11:10 AM

This revision is now accepted and ready to land.Feb 4 2023, 11:10 AM

Closed by commit rCOMM787f0a3b4a6b: [lib] Catch exceptions thrown by ethers.js in ENSCache (authored by ashoat). · Explain WhyFeb 5 2023, 7:53 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM787f0a3b4a6b: [lib] Catch exceptions thrown by ethers.js in ENSCache.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.js

25 lines

Diff 22039

View Options

[lib] Catch exceptions thrown by ethers.js in ENSCacheClosedPublicActions