Paths

Table of Contentst

Differential D6560

[lib] Simplify messageTitle and introduce default for robotext
ClosedPublic
Actions

Authored by ashoat on Feb 3 2023, 12:16 PM.

Tags

None

Referenced Files

	F3294182: D6560.diff
	Sat, Nov 16, 6:35 PM

	Unknown Object (File)
	Fri, Nov 8, 11:04 AM

	Unknown Object (File)
	Mon, Oct 28, 12:39 AM

	Unknown Object (File)
	Mon, Oct 28, 12:39 AM

	Unknown Object (File)
	Mon, Oct 28, 12:39 AM

	Unknown Object (File)
	Mon, Oct 28, 12:38 AM

	Unknown Object (File)
	Sat, Oct 19, 10:21 PM

	Unknown Object (File)
	Sat, Oct 19, 9:56 PM

View All 69 Files

Subscribers

Details

Reviewers

Commits

rCOMMa5af3803c67b: [lib] Simplify messageTitle and introduce default for robotext

Summary

This diff switches messageTitle to returning EntityText as preparation for ENS resolution. I take this opportunity to simplify the logic for global_viewer, and to delete most of the implementations of messageTitle in favor of a default for robotext.

Test Plan

Tested in combination with following diffs, where the message title is actually used. Also Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 3 2023, 12:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 3 2023, 12:16 PM

ashoat added a child revision: D6561: [lib] Add memoization to useMessagePreview.Feb 3 2023, 12:17 PM

Harbormaster completed remote builds in B16071: Diff 21958.Feb 3 2023, 12:37 PM

ashoat requested review of this revision.Feb 3 2023, 12:37 PM

atul accepted this revision.Feb 4 2023, 11:15 AM

atul added inline comments.

lib/utils/entity-text.js
243	Is there an alternative name we could use here that might be more descriptive? Or maybe a comment explaining what `hackedEntity` means? Naming sounds kind of nefarious idk

This revision is now accepted and ready to land.Feb 4 2023, 11:15 AM

Rename

Harbormaster failed remote builds in B16108: Diff 22000!Feb 5 2023, 12:19 AM

This revision was landed with ongoing or failed builds.Feb 5 2023, 7:53 AM

Closed by commit rCOMMa5af3803c67b: [lib] Simplify messageTitle and introduce default for robotext (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa5af3803c67b: [lib] Simplify messageTitle and introduce default for robotext.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

31 lines

messages/

add-members-message-spec.js

27 lines

change-role-message-spec.js

27 lines

change-settings-message-spec.js

25 lines

create-entry-message-spec.js

25 lines

create-sidebar-message-spec.js

36 lines

create-sub-thread-message-spec.js

25 lines

create-thread-message-spec.js

32 lines

delete-entry-message-spec.js

25 lines

edit-entry-message-spec.js

25 lines

join-thread-message-spec.js

30 lines

leave-thread-message-spec.js

30 lines

message-spec.js

4 lines

multimedia-message-spec.js

18 lines

reaction-message-spec.js

18 lines

remove-members-message-spec.js

27 lines

restore-entry-message-spec.js

25 lines

text-message-spec.js

3 lines

unsupported-message-spec.js

30 lines

update-relationship-message-spec.js

29 lines

utils/

22 lines

native/

chat/

chat-item-height-measurer.react.js

3 lines

inner-robotext-message.react.js

2 lines

Diff 21958

lib/shared/message-utils.js

Loading...

lib/shared/messages/add-members-message-spec.js

Loading...

lib/shared/messages/change-role-message-spec.js

Loading...

lib/shared/messages/change-settings-message-spec.js

Loading...

lib/shared/messages/create-entry-message-spec.js

Loading...

lib/shared/messages/create-sidebar-message-spec.js

Loading...

lib/shared/messages/create-sub-thread-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/delete-entry-message-spec.js

Loading...

lib/shared/messages/edit-entry-message-spec.js

Loading...

lib/shared/messages/join-thread-message-spec.js

Loading...

lib/shared/messages/leave-thread-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/multimedia-message-spec.js

Loading...

lib/shared/messages/reaction-message-spec.js

Loading...

lib/shared/messages/remove-members-message-spec.js

Loading...

lib/shared/messages/restore-entry-message-spec.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/shared/messages/unsupported-message-spec.js

Loading...

lib/shared/messages/update-relationship-message-spec.js

Loading...

lib/utils/entity-text.js

Loading...

native/chat/chat-item-height-measurer.react.js

Loading...

native/chat/inner-robotext-message.react.js

Loading...