Paths

Table of Contentst

Differential D6592

[web] Use threadUIName instead of robotextName in ThreadSettingsModal
ClosedPublic
Actions

Authored by ashoat on Feb 5 2023, 2:24 AM.

Details

Reviewers

atul

Commits

rCOMM6c15cb4c3535: [web] Use threadUIName instead of robotextName in ThreadSettingsModal

Summary

I'm about to deprecate robotextName. This diff updates ThreadSettingsModal to figure out a placeholder by resolving a version of the ThreadInfo without the name set.

Depends on D6591

Test Plan

Open and play around with ThreadSettingsModal, clear name to see placeholder

Screenshot 2023-02-04 at 9.45.30 PM.png (1×1 px, 174 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 5 2023, 2:24 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 5 2023, 2:24 AM

ashoat added a child revision: D6593: [native] Fetch ENS names for ThreadInfo uiName in Entry.Feb 5 2023, 2:25 AM

Harbormaster completed remote builds in B16113: Diff 22005.Feb 5 2023, 2:40 AM

ashoat requested review of this revision.Feb 5 2023, 2:40 AM

Make sure ThreadInfo.name isn't set when calling threadUIName

Revert accidental web/package.json change

ashoat edited the test plan for this revision. (Show Details)Feb 5 2023, 2:45 AM

Harbormaster completed remote builds in B16137: Diff 22029.Feb 5 2023, 3:53 AM

Harbormaster completed remote builds in B16138: Diff 22030.Feb 5 2023, 3:57 AM

atul accepted this revision.Feb 5 2023, 6:45 PM

This revision is now accepted and ready to land.Feb 5 2023, 6:45 PM

Closed by commit rCOMM6c15cb4c3535: [web] Use threadUIName instead of robotextName in ThreadSettingsModal. · Explain WhyFeb 5 2023, 8:34 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6c15cb4c3535: [web] Use threadUIName instead of robotextName in ThreadSettingsModal.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

1 line

web/

modals/

threads/

settings/

thread-settings-modal.react.js

21 lines

Diff 22005

View Options

lib/shared/thread-utils.js