[native] Move DeleteThread logic for determining ThreadInfo to hook
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 6:26 PM.

Details

Reviewers

atul

Commits

rCOMM2350c4ec3373: [native] Move DeleteThread logic for determining ThreadInfo to hook

Summary

This mirrors the same migration that we did for this logic in ThreadSettings.

Depends on D6594

Test Plan

Flow, code inspection / comparison to ThreadSettings code. Also tested in combination with following diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 4 2023, 6:26 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 6:26 PM

ashoat added a child revision: D6596: [native] Fetch ENS names in ThreadSettings.Feb 4 2023, 6:27 PM

Harbormaster completed remote builds in B16116: Diff 22008.Feb 4 2023, 6:48 PM

ashoat requested review of this revision.Feb 4 2023, 6:48 PM

atul accepted this revision.Feb 5 2023, 11:26 AM

This revision is now accepted and ready to land.Feb 5 2023, 11:26 AM

Closed by commit rCOMM2350c4ec3373: [native] Move DeleteThread logic for determining ThreadInfo to hook (authored by ashoat). · Explain WhyFeb 5 2023, 12:34 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2350c4ec3373: [native] Move DeleteThread logic for determining ThreadInfo to hook.

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

delete-thread.react.js

34 lines

Diff 22008

View Options

native/chat/settings/delete-thread.react.js

[native] Move DeleteThread logic for determining ThreadInfo to hookClosedPublicActions