Page MenuHomePhabricator
Differential D6615

[lib] Update ThreadInfo.uiName to return an array of UserEntities
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 6:34 PM.
Tags
None
Referenced Files
F3498589: D6615.diff
Thu, Dec 19, 9:35 PM
Unknown Object (File)
Tue, Dec 17, 8:32 PM
Unknown Object (File)
Tue, Dec 17, 8:32 PM
Unknown Object (File)
Tue, Dec 17, 8:32 PM
Unknown Object (File)
Tue, Dec 17, 8:32 PM
Unknown Object (File)
Tue, Dec 17, 8:31 PM
Unknown Object (File)
Tue, Nov 26, 7:10 AM
Unknown Object (File)
Nov 19 2024, 12:50 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMbab60a49f5ee: [lib] Update ThreadInfo.uiName to return an array of UserEntities
Summary

This diff enables all of the diffs below it in the stack to actually work. I had to wait until the last diff to turn everything on because it otherwise would break Flow types.

Depends on D6614

Test Plan

Tested in combination with all of the diffs earlier in the stack

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 4 2023, 6:34 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 6:34 PM
Harbormaster completed remote builds in B16136: Diff 22028.Feb 4 2023, 7:50 PM
ashoat requested review of this revision.Feb 4 2023, 7:50 PM
atul accepted this revision.Feb 5 2023, 11:30 AM
This revision is now accepted and ready to land.Feb 5 2023, 11:30 AM
ashoat updated this revision to Diff 22072.Feb 5 2023, 12:29 PM

Don't pass unused params to threadUIName

This revision was landed with ongoing or failed builds.Feb 5 2023, 12:35 PM
Closed by commit rCOMMbab60a49f5ee: [lib] Update ThreadInfo.uiName to return an array of UserEntities (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMbab60a49f5ee: [lib] Update ThreadInfo.uiName to return an array of UserEntities.
Harbormaster completed remote builds in B16151: Diff 22072.Feb 5 2023, 12:43 PM
ashoat mentioned this in D6628: [lib] Show "just you" for thread title if there are no members besides you.Feb 6 2023, 5:30 AM
ashoat mentioned this in rCOMM181fa7607ab6: [lib] Show "just you" for thread title if there are no members besides you.Feb 6 2023, 9:16 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
39 lines
types/
3 lines
utils/
2 lines
web/
modals/
threads/
settings/
13 lines

Diff 22072

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/entity-text.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...