[native] Flip the switch to enable `SIWE` on `native`
ClosedPublic
Actions

Authored by atul on Feb 5 2023, 11:19 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM1df81b89dc6b: [native] Flip the switch to enable `SIWE` on `native`

Summary

Basically don't gate "Sign in with Ethereum" button on __DEV__ check.

Test Plan

SIWE button appears on prod build as expected. I'm able to log in via Ethereum wallet on prod.

Simulator Screen Shot - iPhone 14 - 2023-02-05 at 18.28.33.png (2×1 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 5 2023, 11:19 PM

atul published this revision for review.Feb 5 2023, 11:19 PM

atul edited the test plan for this revision. (Show Details)Feb 5 2023, 11:28 PM

Harbormaster completed remote builds in B16156: Diff 22106.Feb 5 2023, 11:33 PM

ashoat accepted this revision.Feb 6 2023, 12:41 AM

This revision is now accepted and ready to land.Feb 6 2023, 12:41 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 6 2023, 5:53 PM

Closed by commit rCOMM1df81b89dc6b: [native] Flip the switch to enable `SIWE` on `native`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1df81b89dc6b: [native] Flip the switch to enable `SIWE` on `native`.

Harbormaster completed remote builds in B16179: Diff 22139.Feb 6 2023, 6:11 PM

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

47 lines

Diff 22140

View Options

native/account/logged-out-modal.react.js

[native] Flip the switch to enable `SIWE` on `native`ClosedPublicActions