Page MenuHomePhabricator

[lib] Pluralize NotifTexts.title when it's not a string
ClosedPublic

Authored by ashoat on Feb 6 2023, 5:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 11:11 AM
Unknown Object (File)
Sun, Apr 28, 11:11 AM
Unknown Object (File)
Sun, Apr 28, 11:08 AM
Unknown Object (File)
Sun, Apr 28, 10:50 AM
Unknown Object (File)
Mon, Apr 8, 12:44 PM
Unknown Object (File)
Mar 28 2024, 7:10 PM
Unknown Object (File)
Mar 28 2024, 7:10 PM
Unknown Object (File)
Mar 28 2024, 7:09 PM
Subscribers
None

Details

Summary

In an intermediate revision of D6586 I switched ThreadInfo.uiName from returning a pluralized EntityText directly, to returning an array of UserEntitys that still need to be pluralized. I did this because in some cases we'd want to turn off the behavior of dropping the viewer from the list of viewers, and we would need to do that before pluralization.

However, I forgot to update the code for determining notif texts. Flow didn't catch this because technically an array of UserEntitys is an EntityText, so it didn't see any issues. But the result of this is that the pluralization was skipped, and we got the behavior reported in ENG-2932, which I hadn't noticed during testing since I only tested iOS.

Test Plan

Tested notif in Android emulator and make sure title appears properly pluralized

Screenshot 2023-02-06 at 8.33.25 AM.png (2×1 px, 973 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable