[keyserver][lib] Add COMM_WALLETCONNECT_KEY to Webpack build
ClosedPublic
Actions

Authored by ashoat on Feb 9 2023, 9:38 AM.

Details

Reviewers

atul

Commits

rCOMMf7f965fd1320: [keyserver][lib] Add COMM_WALLETCONNECT_KEY to Webpack build

Summary

This is similar to how we handle COMM_ALCHEMY_KEY. It will be exposed to the Webpack build through the Dockerfile, and additionally it will be exposed to keyserver. (We don't need it there though.)

This addresses ENG-2969

Test Plan

Will test in combination with following diffs

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/siwe

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 9 2023, 9:38 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 9 2023, 9:38 AM

Typo

Harbormaster completed remote builds in B16302: Diff 22302.Feb 9 2023, 9:54 AM

Harbormaster completed remote builds in B16303: Diff 22303.

ashoat requested review of this revision.Feb 9 2023, 9:54 AM

atul accepted this revision.Feb 9 2023, 11:53 AM

This revision is now accepted and ready to land.Feb 9 2023, 11:53 AM

ashoat retitled this revision from [keyserver][lib] Add COMM_WALLETCONNET_KEY to Webpack build to [keyserver][lib] Add COMM_WALLETCONNECT_KEY to Webpack build.Feb 12 2023, 3:31 AM

Closed by commit rCOMMf7f965fd1320: [keyserver][lib] Add COMM_WALLETCONNECT_KEY to Webpack build (authored by ashoat). · Explain WhyFeb 12 2023, 7:48 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf7f965fd1320: [keyserver][lib] Add COMM_WALLETCONNECT_KEY to Webpack build.