Paths

Table of Contentst

Differential D6689

[keyserver] Refactoring rust-node-addon API names
AbandonedPublic
Actions

Authored by • max on Feb 10 2023, 8:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 3:27 PM

	Unknown Object (File)
	Sun, Oct 27, 6:17 PM

	Unknown Object (File)
	Thu, Oct 24, 2:00 AM

	Unknown Object (File)
	Sat, Oct 19, 2:15 AM

	Unknown Object (File)
	Sat, Oct 19, 2:14 AM

	Unknown Object (File)
	Sat, Oct 19, 2:07 AM

	Unknown Object (File)
	Sep 9 2024, 4:32 AM

	Unknown Object (File)
	Sep 5 2024, 1:12 PM

View All 52 Files

Subscribers

Details

Reviewers

varun
tomek

Summary

This diff introduces refactoring of the rust-node-addon function name to reflect that it's only related to the Identity service instead of the global napi-rs Rust library. I think it makes sense to distinguish "getter" between identity and Tunnelbroker client to return a specific flow type in this case and distinguish usage. The Tunnelbroker API client getter will be added in the following D6690.

Linear task: ENG-2613

Test Plan

Passing the CI is enough for these changes.

Diff Detail

Repository

Branch

ks-refactor-addon-rust-api

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Feb 10 2023, 8:02 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 10 2023, 8:02 AM

• max added a parent revision: D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.Feb 10 2023, 8:02 AM

Harbormaster completed remote builds in B16328: Diff 22330.Feb 10 2023, 8:17 AM

• max added a child revision: D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.Feb 10 2023, 9:03 AM

• max edited the summary of this revision. (Show Details)Feb 13 2023, 4:58 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, tomek.

• max published this revision for review.Feb 13 2023, 5:57 AM

i'm good with renaming this, but let's say getIdentityAPI instead of getIdentityRustAPI

keyserver/addons/rust-node-addon/index.js
15
41

This revision is now accepted and ready to land.Feb 13 2023, 2:30 PM

• max removed a child revision: D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.Feb 20 2023, 4:59 AM

Abandoning this revision in a favor of D6690.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

6 lines

Diff 22330

keyserver/addons/rust-node-addon/index.js

Loading...