Page MenuHomePhabricator

[keyserver] Remove experimental flags for Node.js
ClosedPublic

Authored by ashoat on Feb 11 2023, 12:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 4:17 PM
Unknown Object (File)
Sun, Apr 7, 4:17 PM
Unknown Object (File)
Sun, Apr 7, 4:17 PM
Unknown Object (File)
Sun, Apr 7, 4:17 PM
Unknown Object (File)
Sun, Apr 7, 4:15 PM
Unknown Object (File)
Sun, Apr 7, 3:52 PM
Unknown Object (File)
Mar 28 2024, 9:40 PM
Unknown Object (File)
Mar 28 2024, 9:40 PM
Subscribers
None

Details

Summary

Before these diff we had three experimental flags enabled:

  1. --loader - we're keeping this one, which we use to make sure that when we import files in other folders of this monorepo (eg. lib, web, landing), we pass the Babel-transpiled version to Node – otherwise Node gets confused by the Flow annotations
  2. --experimental-json-modules - removing this one, which should have been cut after we addressed ENG-929, which required removing all imports of JSON files in keyserver
  3. --experimental-specifier-resolution=node - removing this one, as it is going after in Node 19 and doesn't work with Webpack 5. The earlier diffs in this stack updated all imports to work without this flag

Depends on D6694

Test Plan

I ran web, landing, keyserver, and native all together and made sure everything still worked

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Nice, maybe this'll reduce noise when running yarn dev in keyserver as well?

All this stuff:

ed102f.png (950×1 px, 931 KB)

This revision is now accepted and ready to land.Feb 12 2023, 3:47 PM

Yeah 2/3 of those are gone now, but there is still one about --loader being experimental