Page MenuHomePhabricator
Differential D6758

[lib][native][web] Include current user as member when calling createPendingThread from baseCreatePendingSidebar
ClosedPublic
Actions

Authored by ashoat on Feb 17 2023, 6:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 12:23 PM
Unknown Object (File)
Nov 24 2024, 4:41 PM
Unknown Object (File)
Nov 20 2024, 1:23 PM
Unknown Object (File)
Nov 20 2024, 1:23 PM
Unknown Object (File)
Nov 20 2024, 1:23 PM
Unknown Object (File)
Nov 20 2024, 1:23 PM
Unknown Object (File)
Nov 15 2024, 9:57 PM
Unknown Object (File)
Nov 2 2024, 1:18 PM
View All 91 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM5e706e8d0be6: [lib][native][web] Include current user as member when calling…
Summary

This diff should be a no-op, as createPendingThread currently separates out the viewer.

In the next diff, we'll update createPendingThread to require the viewer to be passed in as a member, so that we can always have the viewer's username available to us.

Depends on D6757

Test Plan

In combination with diffs I haven't submitted yet, I made sure that @-mentions of the viewer get bolded in a pending sidebar

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
25 lines
native/
chat/
12 lines
25 lines
10 lines
web/
selectors/
9 lines

Diff 22767

View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/sidebar-input-bar-height-measurer.react.js

Loading...
View Options

native/chat/sidebar-navigation.js

Loading...
View Options

native/chat/utils.js

Loading...
View Options

web/selectors/thread-selectors.js

Loading...