Differential D6770
[keyserver] Updating `yarn` scripts to run rust-node-addon build Authored by varun on Feb 20 2023, 2:05 AM. Tags None Referenced Files
Details This diff updating prod and dev yarn scripts for the keyserver to include the building of the rust-node-addon. To build and re-build the rust-node-addon, we should run yarn workspace rust-node-addon build command. Linear task: ENG-3022 Calling yarn prod will build/re-build the rust-node-addon rust library with the production option for the napi-rs.
Diff Detail
Event TimelineComment Actions Since rust-node-addon's build script is already triggered from a postinstall hook, the only change here is to rebuild it every time the user runs yarn dev or yarn prod in keyserver. This seems rather unnecessary for yarn prod, which is rarely run outside of a production setting. As for dev, I think it's rare that somebody working on keyserver will need to rebuild rust-node-addon. Can we design this based on that assumption? At a high level I'm not really sure we need this, so would appreciate more context for why you think it's necessary. Comment Actions Are incremental builds like < 2 seconds or are they going to take a while (eg Rust portion of iOS build)? |