Paths

Table of Contentst

Differential D6793

[native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request
ClosedPublic
Actions

Authored by atul on Feb 20 2023, 3:54 PM.

Tags

None

Referenced Files

	F3619591: D6793.diff
	Wed, Jan 1, 9:42 PM

	Unknown Object (File)
	Nov 22 2024, 1:55 AM

	Unknown Object (File)
	Nov 22 2024, 1:55 AM

	Unknown Object (File)
	Nov 22 2024, 1:55 AM

	Unknown Object (File)
	Nov 22 2024, 1:53 AM

	Unknown Object (File)
	Oct 22 2024, 12:30 PM

	Unknown Object (File)
	Oct 22 2024, 12:30 PM

	Unknown Object (File)
	Oct 22 2024, 3:06 AM

View All 95 Files

Subscribers

Details

Reviewers

Commits

rCOMM649a300eac56: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request

Summary

We added primaryIdentityPublicKey to logInExtraInfo to make it easily accessible in the native RegisterPanel and LogInPanel. However, it led us to include extraneous primaryIdentityPublicKey in siwe_auth request which broke the siwe_auth input validation.

Test Plan

Make sure that SIWE works on native

Simulator Screen Shot - iPhone 14 Pro - 2023-02-20 at 16.00.49.png (2×1 px, 190 KB)

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 20 2023, 3:54 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 20 2023, 3:54 PM

atul published this revision for review.Feb 20 2023, 3:54 PM

atul edited the test plan for this revision. (Show Details)Feb 20 2023, 4:06 PM

Harbormaster completed remote builds in B16650: Diff 22777.Feb 20 2023, 4:08 PM

ashoat accepted this revision.Feb 20 2023, 5:49 PM

This revision is now accepted and ready to land.Feb 20 2023, 5:49 PM

Closed by commit rCOMM649a300eac56: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request (authored by atul). · Explain WhyFeb 20 2023, 8:04 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM649a300eac56: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request.

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

4 lines

Diff 22777

native/account/siwe-panel.react.js

Loading...