Page MenuHomePhabricator

[lib] Add useCreationSideEffectsFunc to MessageSpec
ClosedPublic

Authored by ashoat on Feb 20 2023, 5:47 PM.
Tags
None
Referenced Files
F3249512: D6803.diff
Fri, Nov 15, 3:39 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:52 PM
Unknown Object (File)
Sat, Oct 26, 4:44 PM
Unknown Object (File)
Tue, Oct 22, 9:21 AM
Unknown Object (File)
Fri, Oct 18, 5:04 AM
Subscribers

Details

Summary

This allows us to define a hook that will get called on the client after a message is successfully created. See more context in ENG-3034.

Note that for each MessageType that needs this, a callsite will have to be manually added. That's because we handle message creation differently for each composable type.

Depends on D6802

Test Plan

I tested this stack with the following steps on both web and native:

  1. Make sure users get auto-added to a sidebar when @-mentioned
  2. Test mentions typeahead and make sure it includes all members of parent
  3. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure they are included in the sidebar creation message
  4. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure their name is bolded from the very start of when the message is visible on-screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage