Page MenuHomePhabricator

[web][native] Rename threadMembers in mentions typeahead code to mentionsCandidates
ClosedPublic

Authored by ashoat on Feb 20 2023, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:52 PM
Unknown Object (File)
Sat, Oct 19, 9:26 PM
Unknown Object (File)
Fri, Oct 18, 5:05 AM
Unknown Object (File)
Fri, Oct 18, 5:05 AM
Subscribers

Details

Summary

In a later diff I'm going to update the mentions typeahead to sometimes show results that aren't members of the thread, so I want to rename this variable to avoid misleading the reader.

Depends on D6806

Test Plan

I tested this stack with the following steps on both web and native:

  1. Make sure users get auto-added to a sidebar when @-mentioned
  2. Test mentions typeahead and make sure it includes all members of parent
  3. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure they are included in the sidebar creation message
  4. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure their name is bolded from the very start of when the message is visible on-screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 20 2023, 6:05 PM
Harbormaster failed remote builds in B16665: Diff 22793!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 20 2023, 6:41 PM
Harbormaster failed remote builds in B16672: Diff 22800!
This revision is now accepted and ready to land.Feb 21 2023, 12:25 AM