Page MenuHomePhabricator

[native] Add filtering entitlement to Notification Service Extension
ClosedPublic

Authored by ashoat on Feb 23 2023, 5:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 4:30 AM
Unknown Object (File)
Sun, Nov 3, 8:48 PM
Unknown Object (File)
Tue, Oct 22, 12:30 PM
Unknown Object (File)
Tue, Oct 22, 12:30 PM
Unknown Object (File)
Tue, Oct 22, 3:06 AM
Unknown Object (File)
Mon, Oct 21, 3:58 PM
Unknown Object (File)
Mon, Oct 21, 3:41 PM
Unknown Object (File)
Mon, Oct 21, 3:41 PM
Subscribers

Details

Test Plan

Confirmed that Xcode is able to load the refreshed Provisioning Profile for the Notification Service Extension, and that the relevant entitlement is listed:

Screenshot 2023-02-23 at 8.28.52 AM.png (718×1 px, 301 KB)

In order to test whether the entitlement works as expected complete the following steps:

  1. Modify NotificationService.mm as here: https://gist.github.com/marcinwasowicz/193fb4916b277537a4b7f9e88a456e06
  2. Unblock this flag on keyserver side: https://github.com/CommE2E/comm/blob/master/keyserver/src/push/send.js#L509
  3. Ensure that notification are not displayed even though app is given suitable permission.

This test plan might need to be executed on physical device.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable