[keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table
ClosedPublic
Actions

Authored by atul on Feb 27 2023, 4:07 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMb3a783e613e6: [keyserver] Replace `public_key` column with `signed_identity_keys` in…

Summary

Remove public_key column from the cookies table and replace with signed_identity_keys which will hold primary + notification (ed25519, curve25519) public key pairs (stringified payload with signature).

Test Plan

Migration:
Run the migration and see that DB is as expected:

Create DB:
Close reading, made sure to match social_proof line exactly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 27 2023, 4:07 PM

atul published this revision for review.Feb 27 2023, 4:08 PM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

keyserver/src/database/migration-config.js
177–181 ↗	(On Diff #23202)	I improvised the "styling" here to keep under 80 characters. Happy to change to whatever.
keyserver/src/database/setup-db.js
37 ↗	(On Diff #23202)	This line exceeds 80 characters, but so do many lines in this file so I ascertained that it's chill.

Harbormaster failed remote builds in B16968: Diff 23202!Feb 27 2023, 4:16 PM

So is the format basically { +payload: string, +signature: string }, where payload is the previously agreed upon JSON format?

This revision is now accepted and ready to land.Feb 27 2023, 4:20 PM

Harbormaster completed remote builds in B16968: Diff 23202.Feb 27 2023, 4:36 PM

In D6907#205331, @ashoat wrote:

So is the format basically { +payload: string, +signature: string }, where payload is the previously agreed upon JSON format?

Yeah

rebase + land

This revision was landed with ongoing or failed builds.Feb 27 2023, 5:29 PM

Closed by commit rCOMMb3a783e613e6: [keyserver] Replace `public_key` column with `signed_identity_keys` in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb3a783e613e6: [keyserver] Replace `public_key` column with `signed_identity_keys` in….

Harbormaster failed remote builds in B16970: Diff 23205!Feb 27 2023, 5:37 PM

Harbormaster completed remote builds in B16970: Diff 23205.Feb 27 2023, 5:52 PM