[keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`
ClosedPublic
Actions

Authored by atul on Mar 3 2023, 12:56 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM8d224ecc5edc: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`

Summary

Test Plan

Will be tested in subsequent diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 3 2023, 12:56 PM

atul published this revision for review.Mar 3 2023, 1:07 PM

Harbormaster completed remote builds in B17104: Diff 23427.Mar 3 2023, 1:12 PM

I'd probably include this with another diff tbh... I think it's easier to see stuff like this combined with the usage, and it's easier to put a concrete test plan too

This revision is now accepted and ready to land.Mar 4 2023, 5:08 PM

In D6952#206965, @ashoat wrote:

I'd probably include this with another diff tbh... I think it's easier to see stuff like this combined with the usage, and it's easier to put a concrete test plan too

that's fair, will keep in mind going forward

rebase + land

Harbormaster completed remote builds in B17125: Diff 23459.Mar 5 2023, 11:22 AM

Closed by commit rCOMM8d224ecc5edc: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator` (authored by atul). · Explain WhyMar 5 2023, 12:01 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8d224ecc5edc: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`.