Page MenuHomePhabricator

[keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`
ClosedPublic

Authored by atul on Mar 23 2023, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 7:02 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 9:52 AM
Unknown Object (File)
Fri, Nov 8, 9:52 AM
Unknown Object (File)
Fri, Nov 8, 7:38 AM
Unknown Object (File)
Wed, Nov 6, 3:17 AM
Subscribers
None

Details

Summary

We want to JSON.parse() the stringified avatar from the database before including in LoggedInUserInfo and returning.

Noticed that on user login avatar was a string instead of an object of type ClientAvatar.

The mysql2 node package conveniently "auto parsed" stringified JSON when providing the result set with MySQL, but unfortunately doesn't for MariaDB (https://github.com/sidorares/node-mysql2/issues/1287)... so we need to JSON.parse(...) ourself.

Test Plan

Logged in and avatar was object of type ClientAvatar as expected:

64b3cc.png (324×426 px, 38 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7157 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage