[keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`
ClosedPublic
Actions

Authored by atul on Mar 25 2023, 9:18 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM6d756a2c3195: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on…

Summary

After some discussion we clarified that we do want to include the avatar field for old clients IFF it's set (ie not null).

I mistakenly suggested to @ginsu that we include this check when reviewing D7054 which was my bad.

Test Plan

Avatar should be included in *UserInfo even for older clients.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 25 2023, 9:18 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 25 2023, 9:18 PM

Harbormaster completed remote builds in B17634: Diff 24136.Mar 25 2023, 9:33 PM

atul requested review of this revision.Mar 25 2023, 9:33 PM

ashoat accepted this revision.Mar 25 2023, 11:13 PM

This revision is now accepted and ready to land.Mar 25 2023, 11:13 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 26 2023, 7:10 PM

Closed by commit rCOMM6d756a2c3195: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on…. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6d756a2c3195: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on….

Harbormaster completed remote builds in B17644: Diff 24146.Mar 26 2023, 7:23 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

user-fetchers.js

4 lines

Diff 24147

View Options

keyserver/src/fetchers/user-fetchers.js

[keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`ClosedPublicActions