[keyserver] Add `avatar` to `updateThreadRequestInputValidator.changes`
AbandonedPublic
Actions

Authored by atul on Apr 5 2023, 11:57 AM.

Details

Reviewers

ashoat
ginsu

Summary

So we can include in request to update_thread endpoint. Can reuse updateUserAvatarRequestValidator from user-responders:updateUserAvatarResponder to validate UpdateUserAvatarRequest... which is convenient.

Test Plan

Will be tested implicitly by subsequent diffs (request will fail if the input isn't valid, validator already used in user-responders and has unit tests)

EDIT: Goes through fine:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 5 2023, 11:57 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 5 2023, 11:57 AM

atul published this revision for review.Apr 5 2023, 11:57 AM

Harbormaster completed remote builds in B18018: Diff 24685.Apr 5 2023, 12:13 PM

atul edited the test plan for this revision. (Show Details)Apr 5 2023, 12:27 PM

Can you please combine this diff into the one that updates Flow types, and the upcoming one that will change the actual code? Your pattern of submitting tiny diffs makes it hard to review your changes

This revision now requires changes to proceed.Apr 5 2023, 12:41 PM

atul abandoned this revision.Apr 5 2023, 12:45 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

thread-responders.js

2 lines

Diff 24685

View Options

keyserver/src/responders/thread-responders.js

[keyserver] Add `avatar` to `updateThreadRequestInputValidator.changes`AbandonedPublicActions