Page MenuHomePhabricator

[keyserver][lib] Get rid of unused code for handling videos in mediaFromRow
ClosedPublic

Authored by ashoat on Apr 6 2023, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 1:14 PM
Unknown Object (File)
Sun, Jun 23, 11:00 AM
Unknown Object (File)
Sat, Jun 22, 11:55 AM
Unknown Object (File)
Fri, Jun 21, 6:57 AM
Unknown Object (File)
Wed, Jun 12, 8:31 PM
Unknown Object (File)
Tue, Jun 11, 12:29 PM
Unknown Object (File)
May 28 2024, 11:39 AM
Unknown Object (File)
May 28 2024, 11:39 AM
Subscribers

Details

Summary

This code is actually only ever used for handling messageTypes.IMAGES, which doesn't have any video. We accidentally included it, but it's never used.

Test Plan

To confirm that the fetch path would never hit videos, I ran this query on my production keyserver and got no results:

SELECT m.*, u.type AS upload_type FROM messages m LEFT JOIN uploads u ON u.container = m.id WHERE m.type = 14 AND u.type != 'photo' LIMIT 5;

I also consulted @atul, and we read through the code to make sure the upload path doesn't use messageTypes.IMAGES if there are any videos. Also Flow.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable