Page MenuHomePhabricator
Differential D7642

[native] improve user experience for remvoing an avatar
ClosedPublic
Actions

Authored by ginsu on Apr 26 2023, 5:29 PM.
Tags
None
Referenced Files
F1674224: D7642.diff
Sun, Apr 28, 2:28 PM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:24 AM
Unknown Object (File)
Mon, Apr 22, 8:20 AM
Unknown Object (File)
Mon, Apr 15, 3:38 PM
Unknown Object (File)
Fri, Apr 12, 6:30 PM
View All 70 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM083b8d82f0a1: [native] improve user experience for remvoing an avatar
Summary

This diff does two things to improve the user experince, 1. we change the copy from "Remove avatar" to "Clear avatar" and we exlcude this option too if the avatar is not set

https://linear.app/comm/issue/ENG-3804/remove-avatar-button-does-nothing-if-the-user-has-a-default-avatar

Test Plan

Please see the demo videos to see the changes I made

User avatar:

Thread avatar:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2023, 5:29 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 26 2023, 5:29 PM
ginsu edited the test plan for this revision. (Show Details)Apr 26 2023, 5:33 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F511547: Screen Recording 2023-04-26 at 8.30.57 PM.mov. (Show Details)
ginsu attached a referenced file: F511546: Screen Recording 2023-04-26 at 8.30.27 PM.mov. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B18829: Diff 25797.Apr 26 2023, 5:47 PM
ginsu requested review of this revision.Apr 26 2023, 5:47 PM
ashoat accepted this revision.Apr 27 2023, 10:17 AM
This revision is now accepted and ready to land.Apr 27 2023, 10:17 AM
ginsu updated this revision to Diff 25948.Apr 30 2023, 9:54 PM

rebase before landing

Harbormaster completed remote builds in B18949: Diff 25948.Apr 30 2023, 10:11 PM
Closed by commit rCOMM083b8d82f0a1: [native] improve user experience for remvoing an avatar (authored by ginsu). · Explain WhyApr 30 2023, 10:17 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM083b8d82f0a1: [native] improve user experience for remvoing an avatar.

Revision Contents
Changeset List

PathSize
native/
avatars/
2 lines
27 lines
5 lines

Diff 25955

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...