Page MenuHomePhabricator
Differential D7678

[keyserver] Send `updateTypes.UPDATE_USER` to peers on `updateUserAvatar`
ClosedPublic
Actions

Authored by atul on Apr 27 2023, 1:58 PM.
Tags
None
Referenced Files
F1744715: D7678.id25916.diff
Mon, May 13, 9:52 AM
Unknown Object (File)
Fri, May 10, 4:43 PM
Unknown Object (File)
Fri, May 10, 12:07 PM
Unknown Object (File)
Sun, Apr 14, 5:22 PM
Unknown Object (File)
Sun, Apr 14, 5:22 PM
Unknown Object (File)
Sun, Apr 14, 5:22 PM
Unknown Object (File)
Sun, Apr 14, 5:22 PM
Unknown Object (File)
Sun, Apr 14, 5:22 PM
View All 98 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM2e2ceea7cf20: [keyserver] Send `updateTypes.UPDATE_USER` to peers on `updateUserAvatar`
Summary

We sent UPDATE_USER update to peers on updateUserAvatar. Addresses point 1 of https://linear.app/comm/issue/ENG-3808/updateuseravatar-should-create-update-user-and-update-current-user.

Test Plan

Works as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 27 2023, 1:58 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 27 2023, 1:58 PM
atul published this revision for review.Apr 27 2023, 1:59 PM
atul updated this revision to Diff 25895.Apr 27 2023, 2:00 PM

consistency

atul edited the test plan for this revision. (Show Details)Apr 27 2023, 2:02 PM
ashoat accepted this revision.Apr 27 2023, 2:03 PM
ashoat added inline comments.
keyserver/src/updaters/account-updaters.js
194 ↗(On Diff #25895)

I guess "data" is plural if you attended the University of the UK, but I find it more clear to use "datas"

This revision is now accepted and ready to land.Apr 27 2023, 2:03 PM
atul added inline comments.Apr 27 2023, 2:03 PM
keyserver/src/updaters/account-updaters.js
194 ↗(On Diff #25895)

lol, fair point will update

atul updated this revision to Diff 25896.Apr 27 2023, 2:05 PM

americanize variable names

atul updated this revision to Diff 25897.Apr 27 2023, 2:16 PM

move to own function

so things don't get messy when we add current user update stuff

Harbormaster completed remote builds in B18902: Diff 25894.Apr 27 2023, 2:16 PM
Harbormaster completed remote builds in B18903: Diff 25895.
Harbormaster completed remote builds in B18904: Diff 25896.Apr 27 2023, 2:22 PM
Harbormaster completed remote builds in B18905: Diff 25897.Apr 27 2023, 2:34 PM
atul updated this revision to Diff 25916.Apr 28 2023, 11:21 AM

rebase and land

This revision was landed with ongoing or failed builds.Apr 28 2023, 11:23 AM
Closed by commit rCOMM2e2ceea7cf20: [keyserver] Send `updateTypes.UPDATE_USER` to peers on `updateUserAvatar` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM2e2ceea7cf20: [keyserver] Send `updateTypes.UPDATE_USER` to peers on `updateUserAvatar`.
Harbormaster completed remote builds in B18920: Diff 25916.Apr 28 2023, 11:37 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
37 lines

Diff 25917

View Options

keyserver/src/updaters/account-updaters.js

Loading...