[keyserver] Add `COMMUNITY_[ANNOUNCEMENT_]ROOT` to `newThreadRequestInputValidator`
ClosedPublic
Actions

Authored by atul on May 10 2023, 9:57 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM434c16a90efc: [keyserver] Add `COMMUNITY_[ANNOUNCEMENT_]ROOT` to…

Summary

This change allows us to create new COMMUNITY_ROOT and COMMUNITY_ANNOUNCEMENT_ROOT threads via the create_thread endpoint. Based on what I've read, I think that should be fine, but please let me know if there's some context I'm missing.

Test Plan

Able to create COMMUNITY_ANNOUNCEMENT_ROOT as expected:

Screen Shot 2023-05-10 at 7.02.47 PM.png (590×604 px, 37 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 10 2023, 9:57 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 10 2023, 9:57 AM

atul published this revision for review.May 10 2023, 10:03 AM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B19255: Diff 26357.May 10 2023, 10:15 AM

ashoat accepted this revision.May 12 2023, 2:10 AM

This revision is now accepted and ready to land.May 12 2023, 2:10 AM

rebase and land

This revision was landed with ongoing or failed builds.May 15 2023, 7:54 AM

Closed by commit rCOMM434c16a90efc: [keyserver] Add `COMMUNITY_[ANNOUNCEMENT_]ROOT` to… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM434c16a90efc: [keyserver] Add `COMMUNITY_[ANNOUNCEMENT_]ROOT` to….

Harbormaster completed remote builds in B19339: Diff 26464.May 15 2023, 8:14 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

thread-responders.js

2 lines

Diff 26466

View Options

keyserver/src/responders/thread-responders.js

[keyserver] Add `COMMUNITY_[ANNOUNCEMENT_]ROOT` to `newThreadRequestInputValidator`ClosedPublicActions