Page MenuHomePhabricator
Differential D7862

[web] Remove unnecessary `newThreadResult` check in `CommunityCreationModal`
ClosedPublic
Actions

Authored by atul on May 18 2023, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 2:06 AM
Unknown Object (File)
Tue, Mar 18, 12:47 PM
Unknown Object (File)
Mar 1 2025, 9:37 AM
Unknown Object (File)
Mar 1 2025, 9:37 AM
Unknown Object (File)
Mar 1 2025, 9:37 AM
Unknown Object (File)
Mar 1 2025, 9:35 AM
Unknown Object (File)
Mar 1 2025, 9:03 AM
Unknown Object (File)
Feb 23 2025, 2:24 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM2bd45c48ebb9: [web] Remove unnecessary `newThreadResult` check in `CommunityCreationModal`
Summary

Addresses: https://phab.comm.dev/D7847#inline-51293

Test Plan

Things continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
sidebar/
community-creation/
20 lines

Diff 26678

View Options

web/sidebar/community-creation/community-creation-modal.react.js

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines): ReduceMessageStoreResult {
) { ) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible( const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload, action.payload,
newThreadInfos, newThreadInfos,
); );
const { localID, threadID } = payload; const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`); invariant(localID, `localID should be set on ${action.type}`);
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
if (!messageStore.messages[localID]) {
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
}
const messageStoreOperations = [ const messageStoreOperations = [
{ {
type: 'replace', type: 'replace',
payload: { id: localID, messageInfo: payload }, payload: { id: localID, messageInfo: payload },
}, },
]; ];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const now = Date.now(); const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? []; let updatedThreads;
let local = { ...messageStore.local };
if (messageStore.messages[localID]) { if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload }; const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy( local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID, (localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local); )(messageStore.local);
const thread = messageStore.threads[threadID]; const thread = messageStore.threads[threadID];
const threads = { updatedThreads = {
...messageStore.threads,
[threadID]: { [threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs), messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true, startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now, lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now, lastPruned: thread?.lastPruned ?? now,
}, },
}; };
return { } else {
messageStoreOperations, updatedThreads = {
messageStore: { [threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? { ? {
...messageStore.threads[threadID], ...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs], messageIDs: [localID, ...messageIDs],
} }
: { : {
messageIDs: [localID], messageIDs: [localID],
startReached: true, startReached: true,
lastNavigatedTo: now, lastNavigatedTo: now,
lastPruned: now, lastPruned: now,
},
}; };
}
return { const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads, ...messageStore.threads,
[threadID]: threadState, ...updatedThreads,
};
messageStoreOperations.push({
type: 'replace_threads',
payload: {
threads: { ...updatedThreads },
}, },
local: messageStore.local, });
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const newMessageStore = {
messages: processedMessageStore.messages,
threads,
local,
currentAsOf: messageStore.currentAsOf, currentAsOf: messageStore.currentAsOf,
}, };
assertMessageStoreThreadsAreEqual(
processedMessageStore,
newMessageStore,
action.type,
);
return {
messageStoreOperations,
messageStore: newMessageStore,
}; };
} else if ( } else if (
action.type === sendTextMessageActionTypes.failed || action.type === sendTextMessageActionTypes.failed ||
action.type === sendMultimediaMessageActionTypes.failed action.type === sendMultimediaMessageActionTypes.failed
) { ) {
const { localID } = action.payload; const { localID } = action.payload;
return { return {
messageStoreOperations: [], messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines