[native] Rename avatar action sheet actions
ClosedPublic
Actions

Authored by ashoat on Jun 1 2023, 1:57 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM575b39a70f57: [native] Rename avatar action sheet actions

Summary

Initially I just wanted to rename the "Reset to default" option for clarity, but ended up making several changes:

Rename "Clear avatar" to "Reset to default" to avoid implying to the user that they can use Comm without an avatar
- In the "update avatar" flow, the verb "clear" makes more sense since it clears changes. In the registration flow, it seems more ambiguous... feels like it might imply that you can register without an avatar
Be more consistent with capitalization
Start each option with a verb for consistency

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 1 2023, 1:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 1 2023, 1:57 PM

Harbormaster completed remote builds in B19970: Diff 27378.Jun 1 2023, 2:15 PM

ashoat requested review of this revision.Jun 1 2023, 2:15 PM

ginsu accepted this revision.Jun 1 2023, 3:30 PM

This revision is now accepted and ready to land.Jun 1 2023, 3:30 PM

Closed by commit rCOMM575b39a70f57: [native] Rename avatar action sheet actions (authored by ashoat). · Explain WhyJun 1 2023, 3:45 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM575b39a70f57: [native] Rename avatar action sheet actions.

atul mentioned this in D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.Aug 2 2023, 12:50 AM

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

8 lines

Diff 27380

View Options

native/avatars/avatar-hooks.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines	if (!hasNonce) {
return (		return (
<div className={css.wrapper}>		<div className={css.wrapper}>
<div className={css.walletDisplay}>		<div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span>		<span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton />		<ConnectButton />
</div>		</div>
<p>{siweMessageSigningExplanationStatements[0]}</p>		<p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p>		<p>{siweMessageSigningExplanationStatements[1]}</p>
		<p>
		By signing up, you agree to our{' '}
		<a href="https://comm.app/terms">Terms of Use</a> &{' '}
		<a href="https://comm.app/privacy">Privacy Policy</a>.
		</p>
<div className={css.button} onClick={onClick}>		<div className={css.button} onClick={onClick}>
Sign in		Sign in
</div>		</div>
</div>		</div>
);		);
}		}
}		}

Show All 22 Lines

[native] Rename avatar action sheet actionsClosedPublicActions