Page MenuHomePhabricator

[native] Rename avatar action sheet actions
ClosedPublic

Authored by ashoat on Jun 1 2023, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 10 2024, 12:32 PM
Unknown Object (File)
Nov 9 2024, 4:04 AM
Unknown Object (File)
Nov 1 2024, 8:20 AM
Unknown Object (File)
Nov 1 2024, 8:20 AM
Unknown Object (File)
Oct 15 2024, 4:54 AM
Unknown Object (File)
Sep 26 2024, 5:55 PM
Unknown Object (File)
Sep 26 2024, 5:55 PM
Unknown Object (File)
Sep 26 2024, 5:55 PM
Subscribers

Details

Summary

Initially I just wanted to rename the "Reset to default" option for clarity, but ended up making several changes:

  1. Rename "Clear avatar" to "Reset to default" to avoid implying to the user that they can use Comm without an avatar
    • In the "update avatar" flow, the verb "clear" makes more sense since it clears changes. In the registration flow, it seems more ambiguous... feels like it might imply that you can register without an avatar
  2. Be more consistent with capitalization
  3. Start each option with a verb for consistency
Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable