Page MenuHomePhabricator
Differential D8199

[web, lib] Extract function for modyfing items to be displayed in MessageResult
ClosedPublic
Actions

Authored by inka on Jun 13 2023, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 6:36 AM
Unknown Object (File)
Mon, Apr 8, 6:36 AM
Unknown Object (File)
Mon, Apr 8, 6:33 AM
Unknown Object (File)
Thu, Apr 4, 7:01 AM
Unknown Object (File)
Wed, Apr 3, 8:45 PM
Unknown Object (File)
Mar 5 2024, 5:56 AM
Unknown Object (File)
Mar 5 2024, 5:55 AM
Unknown Object (File)
Mar 5 2024, 5:55 AM
View All 34 Files
Subscribers
ashoat
tomek

Details

Reviewers
rohan
Commits
rCOMM534cec910d78: [web, lib] Extract function for modyfing items to be displayed in MessageResult
Summary

issue: https://linear.app/comm/issue/ENG-3462/add-modal-for-searching-messages and https://linear.app/comm/issue/ENG-4092/pin-message-modal-displaying-the-message-incorrectly
Extracting a function that will be needed in message search. Using it in TogglePinModal to fix avatar not showing because startsCluster and endsCluster were not being set to true.

Test Plan

Checked that avatars show in TogglePinModal for messages in the middle of the cluster, checked that pinned messages modal still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
23 lines
web/
modals/
chat/
34 lines
12 lines

Diff 27715

View Options

lib/shared/message-utils.js

Loading...
View Options

web/modals/chat/message-results-modal.react.js

Loading...
View Options

web/modals/chat/toggle-pin-modal.react.js

Loading...