Differential D8203

[native] add missing entries in CMakeLists
ClosedPublic
Actions

Authored by kamil on Jun 14 2023, 3:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 4, 1:25 AM

	Unknown Object (File)
	Tue, Mar 4, 1:25 AM

	Unknown Object (File)
	Tue, Mar 4, 1:25 AM

	Unknown Object (File)
	Tue, Mar 4, 1:22 AM

	Unknown Object (File)
	Wed, Feb 26, 1:10 AM

	Unknown Object (File)
	Mon, Feb 24, 11:29 AM

	Unknown Object (File)
	Feb 13 2025, 10:15 AM

	Unknown Object (File)
	Feb 13 2025, 10:15 AM

Subscribers

Details

Reviewers

Commits

rCOMMef9b03b1e97c: [native] add missing entries in CMakeLists

Summary

Context in ENG-4090.

Test Plan

Build Android

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 14 2023, 3:22 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 14 2023, 3:22 AM

Harbormaster completed remote builds in B20237: Diff 27719.Jun 14 2023, 3:39 AM

kamil published this revision for review.Jun 14 2023, 3:48 AM

• jon accepted this revision.Jun 14 2023, 7:37 AM

This revision is now accepted and ready to land.Jun 14 2023, 7:37 AM

Closed by commit rCOMMef9b03b1e97c: [native] add missing entries in CMakeLists (authored by kamil). · Explain WhyJun 14 2023, 8:17 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMef9b03b1e97c: [native] add missing entries in CMakeLists.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

2 lines

Diff 27748

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

	project(comm-modules)			project(comm-modules)
	cmake_minimum_required(VERSION 3.4)			cmake_minimum_required(VERSION 3.4)

	# For C++17 on MacOS, we must set minimum target to 10.14+			# For C++17 on MacOS, we must set minimum target to 10.14+
	set(CMAKE_CXX_STANDARD 17)			set(CMAKE_CXX_STANDARD 17)
	set(CMAKE_OSX_DEPLOYMENT_TARGET 10.14)			set(CMAKE_OSX_DEPLOYMENT_TARGET 10.14)

	include(GNUInstallDirs)			include(GNUInstallDirs)

	set(NATIVE_HDRS			set(NATIVE_HDRS
	"CommCoreModule.h"			"CommCoreModule.h"
	"CommUtilsModule.h"			"CommUtilsModule.h"
	"MessageStoreOperations.h"			"MessageStoreOperations.h"
	"ThreadStoreOperations.h"			"ThreadStoreOperations.h"
				"ReportStoreOperations.h"
				"DraftStoreOperations.h"
	)			)

	set(NATIVE_SRCS			set(NATIVE_SRCS
	"CommCoreModule.cpp"			"CommCoreModule.cpp"
	"CommUtilsModule.cpp"			"CommUtilsModule.cpp"
	)			)

	add_library(comm-modules-native			add_library(comm-modules-native
	▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines