Page MenuHomePhabricator
Differential D8326

[Docs] Mention Chrome needs to be restarted
ClosedPublic
Actions

Authored by • jon on Jun 27 2023, 6:04 AM.
Tags
None
Referenced Files
F2168706: D8326.id.diff
Tue, Jul 2, 9:33 AM
F2166102: D8326.id28162.diff
Tue, Jul 2, 3:23 AM
Unknown Object (File)
Sat, Jun 29, 9:26 PM
Unknown Object (File)
Mon, Jun 10, 7:23 PM
Unknown Object (File)
Thu, Jun 6, 1:21 AM
Unknown Object (File)
Sun, Jun 2, 10:31 PM
Unknown Object (File)
Sun, Jun 2, 10:31 PM
Unknown Object (File)
May 31 2024, 6:36 AM
View All 88 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM8d63c6591600: [Docs] Mention Chrome needs to be restarted
Summary

Otherwise the extensions won't appear for the user.

Part of https://linear.app/comm/issue/ENG-2527

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jun 27 2023, 6:04 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 6:04 AM
Harbormaster completed remote builds in B20535: Diff 28162.Jun 27 2023, 6:22 AM
• jon requested review of this revision.Jun 27 2023, 6:22 AM
ashoat requested changes to this revision.Jun 28 2023, 5:09 PM

I wish I didn't have to rewrite every single docs diff...

  1. Can we put this in docs/nix_web_setup.md instead? It only needs to be considered when installing the extensions, so we should document it there (instead of in the use section)
  2. Can we mention this for both extensions?
docs/nix_web_workflows.md
79 ↗(On Diff #28162)

This is repetitive, and refers to "extensions" in the plural when the section it's in is only talking about one extension

This revision now requires changes to proceed.Jun 28 2023, 5:09 PM
• jon marked an inline comment as done.Jul 4 2023, 1:10 PM
• jon updated this revision to Diff 28388.Jul 4 2023, 1:11 PM

Move instruction to web setup

• jon updated this revision to Diff 28389.Jul 4 2023, 1:12 PM

Mention for both extensions

• jon added a comment.Jul 4 2023, 1:12 PM

Address feedback

Harbormaster completed remote builds in B20718: Diff 28388.Jul 4 2023, 1:32 PM
Harbormaster completed remote builds in B20719: Diff 28389.
ashoat accepted this revision.Jul 4 2023, 6:34 PM
This revision is now accepted and ready to land.Jul 4 2023, 6:34 PM
Closed by commit rCOMM8d63c6591600: [Docs] Mention Chrome needs to be restarted (authored by • jon). · Explain WhyJul 6 2023, 3:41 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM8d63c6591600: [Docs] Mention Chrome needs to be restarted.

Revision Contents
Changeset List

PathSize
docs/
4 lines

Diff 28460

View Options

docs/nix_web_setup.md

Loading...