Paths

Table of Contentst

[web][lib][landing] Prevent crash when missing WalletConnect key
ClosedPublic
Actions

Authored by ashoat on Jun 27 2023, 9:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 2:01 AM

	Unknown Object (File)
	Tue, Dec 17, 2:01 AM

	Unknown Object (File)
	Tue, Dec 17, 2:01 AM

	Unknown Object (File)
	Tue, Dec 17, 2:00 AM

	Unknown Object (File)
	Nov 23 2024, 2:24 PM

	Unknown Object (File)
	Nov 23 2024, 1:20 PM

	Unknown Object (File)
	Nov 23 2024, 1:20 PM

	Unknown Object (File)
	Nov 23 2024, 12:42 PM

View All 99 Files

Subscribers

tomek

Details

Reviewers

kamil
atul

Commits

rCOMM71601d39d173: [web][lib][landing] Prevent crash when missing WalletConnect key

Summary

See ENG-4175 for context.

Test Plan

I moved my keyserver/secrets/walletconnect.json file to another path. Without this diff the web app was crashing, but after this diff it was able to load successfully.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 27 2023, 9:24 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 9:24 PM

Harbormaster completed remote builds in B20567: Diff 28202.Jun 27 2023, 9:42 PM

ashoat requested review of this revision.Jun 27 2023, 9:42 PM

I checked and it resolved the issue for me

This revision is now accepted and ready to land.Jun 28 2023, 1:49 AM

Closed by commit rCOMM71601d39d173: [web][lib][landing] Prevent crash when missing WalletConnect key (authored by ashoat). · Explain WhyJun 28 2023, 3:57 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM71601d39d173: [web][lib][landing] Prevent crash when missing WalletConnect key.

Revision Contents
Changeset List

Path

Size

landing/

siwe.react.js

23 lines

lib/

utils/

wagmi-utils.js

23 lines

Diff 28238

View Options

landing/siwe.react.js