Details
- Run web app
- Create subchannel with some threads (sidebars)
- Check if threads are searchable
- Delete subchannel and check if threads are still searchable
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Great work! Mostly nits inline
keyserver/src/deleters/thread-deleters.js | ||
---|---|---|
60 ↗ | (On Diff #28465) | Let's delete this line |
65 ↗ | (On Diff #28465) | serverThreadInfo is an array. We typically try to use plurals for arrays. The English word "information" is technically both singular and plural, but to disambiguate in the code we generally try to use the suffix "Infos" |
93 ↗ | (On Diff #28465) | The convention in the codebase is to omit semicolons at the end of SQL statements unless using multipleStatements: true It's best to try to match conventions as much as possible, rather than changing things to match your preference. Please try to identify conventions on your own, and try to match the style in the codebase as much as possible! |
98 ↗ | (On Diff #28465) | Nit: convention in the code is to use capital letter for the second letter of ID |
keyserver/src/fetchers/thread-fetchers.js | ||
312 ↗ | (On Diff #28465) | Nit |
313 ↗ | (On Diff #28465) | I don't think we need this condition here, as it doesn't appear to be used in your use case. It's best to keep things as simple as possible, and avoid "overengineering" for potential future use cases. If we need this in the future, it should be really easy to reintroduce it |
332 ↗ | (On Diff #28465) |