Paths

Table of Contentst

[landing] decrease spacing between paragraphs in landing page info blocks
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 12:43 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM14ce9b0351a2: [landing] decrease spacing between paragraphs in landing page info blocks

Summary

@ashoat brought this up IRL, this diff addresses decreasing the spacing between paragraphs from 40px => 24px.

Test Plan

Please see screenshots below

Before:

Screenshot 2023-08-15 at 3.40.22 PM.png (2×3 px, 865 KB)

Screenshot 2023-08-15 at 3.40.24 PM.png (2×3 px, 820 KB)

After:

Screenshot 2023-08-15 at 3.40.02 PM.png (2×3 px, 830 KB)

Screenshot 2023-08-15 at 3.40.04 PM.png (2×3 px, 870 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 15 2023, 12:43 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 15 2023, 12:43 PM

Harbormaster completed remote builds in B21772: Diff 29925.Aug 15 2023, 1:02 PM

ginsu requested review of this revision.Aug 15 2023, 1:02 PM

quick fix

ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 1:06 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu attached a referenced file: F690401: Screenshot 2023-08-15 at 3.40.04 PM.png. (Show Details)

ginsu attached a referenced file: F690400: Screenshot 2023-08-15 at 3.40.02 PM.png. (Show Details)

ginsu attached a referenced file: F690398: Screenshot 2023-08-15 at 3.40.24 PM.png. (Show Details)

ginsu attached a referenced file: F690399: Screenshot 2023-08-15 at 3.40.22 PM.png. (Show Details)

ginsu added inline comments.

landing/info-block.css
23 ↗	(On Diff #29926)	We add 16px here since we removed 16px from the `paragraph` class below

ginsu added inline comments.Aug 15 2023, 1:15 PM

landing/landing.css
44 ↗	(On Diff #29926)	Switched from `margin` to `padding` here since this was causing margin collapse

ashoat accepted this revision.Aug 15 2023, 1:21 PM

This revision is now accepted and ready to land.Aug 15 2023, 1:21 PM

Harbormaster completed remote builds in B21773: Diff 29926.Aug 15 2023, 1:24 PM

Closed by commit rCOMM14ce9b0351a2: [landing] decrease spacing between paragraphs in landing page info blocks (authored by ginsu). · Explain WhyAug 15 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM14ce9b0351a2: [landing] decrease spacing between paragraphs in landing page info blocks.

Revision Contents
Changeset List

Path

Size

landing/

info-block.css

1 line

landing.css

2 lines

Diff 29927

View Options

landing/info-block.css