This has a similar problem to the parent diff. I refactored it to use two queries, the second of which is the same as in the parent diff.
Depends on D8837
Details
Details
- Performance: I tested the query on my production keyserver and found that it took less than 0.1s.
- Correctness: I created an "inaccessible thread" in my local dev environment by manually running an INSERT INTO threads query. I then triggered the cronjob manually by changing the time it runs, and confirmed my new thread was deleted. I also ran it when no threads needed to be deleted, and confirmed nothing happened via console.loging the code in the function.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The diff here is kind of hard to read. What I did was:
- Extract the SQL query I crafted in the previous diff into a new function deleteThreadsFromDB.
- Split deleteInaccessibleThreads into two queries, the first of which simply finds the inaccessible threads, and the second being a call to deleteThreadsFromDB.