Page MenuHomePhabricator
Differential D8919

[web] Fix `ThreadSettingsModal` and flip switch to enable `EditThreadAvatar`
ClosedPublic
Actions

Authored by atul on Aug 22 2023, 11:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 3:22 PM
Unknown Object (File)
Fri, Sep 13, 3:22 PM
Unknown Object (File)
Fri, Sep 13, 3:22 PM
Unknown Object (File)
Fri, Sep 13, 3:18 PM
Unknown Object (File)
Aug 27 2024, 6:52 PM
Unknown Object (File)
Aug 27 2024, 9:59 AM
Unknown Object (File)
Aug 27 2024, 7:12 AM
Unknown Object (File)
Aug 11 2024, 2:30 PM
View All 48 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM4e6ec7271f90: [web] Fix `ThreadSettingsModal` and flip switch to enable `EditThreadAvatar`
Summary

Merged the fixing of layout and "flipping of switch" for convenience.

Test Plan

Looks as expected (and works as expected). Here's how each tab of ThreadSettingsModal looks now:

e87dbf.png (1×818 px, 65 KB)

57e9ff.png (1×840 px, 86 KB)

fe7fe1.png (1×860 px, 130 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Aug 22 2023, 11:41 AM
Herald added a subscriber: tomek. · View Herald TranscriptAug 22 2023, 11:41 AM
atul edited the test plan for this revision. (Show Details)Aug 22 2023, 11:42 AM
atul published this revision for review.Aug 22 2023, 11:45 AM
atul added inline comments.
web/modals/threads/settings/thread-settings-general-tab.react.js
153–155 ↗(On Diff #30244)

Since I was going to introduce a div here for the layout I just went ahead and "flipped the switch" since things are good after this diff.

Harbormaster completed remote builds in B22030: Diff 30244.Aug 22 2023, 11:59 AM
ginsu accepted this revision.Aug 22 2023, 12:15 PM
This revision is now accepted and ready to land.Aug 22 2023, 12:15 PM
Closed by commit rCOMM4e6ec7271f90: [web] Fix `ThreadSettingsModal` and flip switch to enable `EditThreadAvatar` (authored by atul). · Explain WhyAug 22 2023, 12:17 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4e6ec7271f90: [web] Fix `ThreadSettingsModal` and flip switch to enable `EditThreadAvatar`.

Revision Contents
Changeset List

Diff 30246

View Options

web/modals/threads/settings/thread-settings-general-tab.css

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.css

Loading...